Docs / Everyday work
Reviewing pull requests
Review a teammate's pull request with the whole repo at hand, and an agent beside you that reviews it, explains the tricky parts and answers your questions.
Open a review
A review opens the pull request in a pane of its own, focused on its diff. Open one from:
- Review Requests at the top of the PRs list (⌘2): the pull requests waiting on you. Click one, or any other pull request in the list. A request leaves the list once you've reviewed it; to set one aside, hover it and click its ✕. Either way it comes back if you're asked to review it again. To tell the author you're not reviewing it, right-click it and choose Remove Me as Reviewer; a request made to one of your teams is only dismissed.
- The Review button on any pull request you have open in Flotilla.
- File › Review Pull Request… (⇧⌘R): paste its link.
Conversation at the top opens the whole pull request: its discussion, checks and merge button.
When one of your projects has the repo, the first time you ask for the AI review, ask a question, ⌘-click a name or show more of a file, Flotilla checks the pull request out in a review session of that project and starts its agent in the background. Agent at the top shows it beside the review. On a repo that isn't in any of your projects you can still leave comments and submit your review; the AI review, questions and ⌘-click need the repo in a project.
Read the diff
The diff shows only what changed, and the rest of the repo is a click away:
| ⌘-click | Jump to where a name is declared, in the editor. |
| Show more | The button on a file's header shows more of the file around the changes, then all of it. The one beside it goes back to just the changes. |
| Fold | The arrow on a file's header folds it away. |
| Folded changes | Changes that need no close reading start folded to one line saying why: whitespace only, imports only, or code moved from elsewhere in the pull request. Click the line to see them. |
| Viewed | Tick it on a file's header to fold the file and check it off in the list, the same box as on GitHub. It unticks itself when the file changes. |
Comment, then submit PRO
Hover over a line and click + to comment on it. Shift-click a second + to comment on a range of lines, or use the + on a file's header for the whole file.
Comments are drafts: nothing reaches GitHub until you click Submit Review… under the diff and choose Comment, Approve or Request Changes. They all go out together as one review.
Review with AI PRO
Click Review with AI above the diff. The agent reads the pull request, and the code around it, and leaves short notes on the lines they're about:
- Findings: bugs, risks and better approaches.
- Context: why something was done the way it was, especially where it looks odd. Each says where that comes from: the pull request, the code's history, or the agent's own reading.
- A reading guide: what the pull request does, the order to read the files in, and which files and changes are mechanical. Those start folded. Click a file it names to jump to it.
- A recommendation: approve or request changes, and why.
None of it is posted. Click Adopt on a note to copy it into a draft comment of yours, or Select… to adopt several at once. Findings and Context above the diff show or hide each kind.
Ask the agent PRO
Wondering why something is there? Write your question where you'd write a comment and click Ask Agent (⌥⌘↩). The answer appears right under it, and Reply asks a follow-up. For a question about the whole pull request, use the field above the diff.
When the agent can't tell, Ask the Author turns your question into a draft comment for whoever wrote the pull request.
When the pull request changes
New commits show a banner above the diff. Update Checkout moves your review to them: notes and drafts follow their lines, and any whose lines changed fold into outdated under their file. Then Review the New Commits has the agent look at just what's new.
Make it yours
Settings › Review sets how many findings the agent writes, how strict its recommendation is, whether it explains the code, how it words things, and instructions of your own, for every review or one project. It also chooses which review requests show: how long one may go without activity, requests to your teams, drafts, bots, and specific authors or repos, each matched exactly, by part of the name or by a regex.
The agent works out of sight, not as a session in the sidebar; Show Agent brings it up beside the review. It stops a few minutes after you close the review, once it's done, and when you quit. Your drafts and the agent's notes stay with the pull request for two weeks after you last touched them. To throw them away sooner, choose End Review… on its row in Review Requests.
Flotilla